Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add XR_FB_hand_tracking_capsules extension wrapper #116

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Add XR_FB_hand_tracking_capsules extension wrapper #116

merged 1 commit into from
Apr 19, 2024

Conversation

devloglogan
Copy link
Collaborator

@devloglogan devloglogan commented Apr 4, 2024 •
edited
Loading

This PR is a simplified version of my original XR_FB_hand_tracking_capsules extension wrapper (#88), just exposing the extension's capsule data in the wrapper with the following functions:

get_hand_capsule_count()
get_hand_capsule_transform(int p_hand_index, int p_capsule_index)
get_hand_capsule_height(int p_hand_index, int p_capsule_index)
get_hand_capsule_radius(int p_hand_index, int p_capsule_index)
get_hand_capsule_joint(int p_hand_index, int p_capsule_index)

This data can be used to construct capsule meshes or collision shapes when desired.

If this PR is merged, both #88 and Godot PR godotengine/godot#89289 can be closed.

@m4gr3d m4gr3d added this to the 3.0.0 milestone Apr 5, 2024
@m4gr3d m4gr3d added the enhancement New feature or request label Apr 5, 2024
m4gr3d
m4gr3d approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@m4gr3d
Copy link
Collaborator

m4gr3d commented Apr 5, 2024

If this PR is merged, both #88 and Godot PR godotengine/godot#89289 can be closed.

I'm curious about the decision to close #88. I thought that PR would provide the sphere derived capsule data as mentioned in #88 (comment), while this wrapper would provide the vendor capsule data as an alternative; is that not the case?

@devloglogan
Copy link
Collaborator Author

I'm curious about the decision to close #88. I thought that PR would provide the sphere derived capsule data as mentioned in #88 (comment), while this wrapper would provide the vendor capsule data as an alternative; is that not the case?

The discussion around providing capsule data derived from the spheres arose because it would be a vendor neutral way of creating similar data. Users can already construct that data themselves by using functions in OpenXRInterface to get the sphere data and doing the conversions. So if we were going to add something to help with that, it would probably be some functions in OpenXRInterface/OpenXRHandTrackingExtension that would convert that data for users internally. And that would be a different PR to Godot itself, not the vendor repo, so #88 could be closed.

@m4gr3d
Copy link
Collaborator

m4gr3d commented Apr 19, 2024

@devloglogan Can you rebase this PR so we can merge it in!

@devloglogan
Copy link
Collaborator Author

Rebased!

@m4gr3d m4gr3d merged commit 300c554 into GodotVR:master Apr 19, 2024
7 checks passed
@devloglogan devloglogan deleted the fb-capsules-data branch April 19, 2024 13:06
This was referenced Apr 19, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4gr3d m4gr3d m4gr3d approved these changes

@dsnopek dsnopek Awaiting requested review from dsnopek

@Malcolmnixon Malcolmnixon Awaiting requested review from Malcolmnixon

@BastiaanOlij BastiaanOlij Awaiting requested review from BastiaanOlij

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@devloglogan @m4gr3d